From: Daniel Vetter Date: Thu, 10 Sep 2015 20:39:22 +0000 (+0200) Subject: drm: Nuke drm_framebuffer->helper_private X-Git-Tag: v4.4-rc1~66^2~31^2~28 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c86fb9d997428e0d55ab5a47488b6ba3bc4b5c5b;p=thirdparty%2Fkernel%2Flinux.git drm: Nuke drm_framebuffer->helper_private It's completely unused and there's really no reason for this: - drm_framebuffer structures are invariant after creation, no need for helpers to manipulate them. - drm_framebuffer structures should just be embedded (and that's what all the drivers do). Stumbled over this since some folks are apparently concerned with the overhead of struct drm_framebuffer and this is an easy 8 byte saving. More could be gained by ditching the legacy fields and recomputing stuff from the fourcc value. But that would require some drm-wide cocci and real justification. Cc: gary.k.smith@intel.com Reviewed-by: David Herrmann Signed-off-by: Daniel Vetter --- diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 75f49c1ef8bb7..c0366e9152e20 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -210,8 +210,6 @@ struct drm_framebuffer { int flags; uint32_t pixel_format; /* fourcc format */ struct list_head filp_head; - /* if you are using the helper */ - void *helper_private; }; struct drm_property_blob {