From: Florian Westphal Date: Tue, 20 Aug 2024 09:56:14 +0000 (+0200) Subject: netfilter: nf_tables: don't initialize registers in nft_do_chain() X-Git-Tag: v6.12-rc1~232^2~192^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c88baabf16d1ef74ab8832de9761226406af5507;p=thirdparty%2Fkernel%2Flinux.git netfilter: nf_tables: don't initialize registers in nft_do_chain() revert commit 4c905f6740a3 ("netfilter: nf_tables: initialize registers in nft_do_chain()"). Previous patch makes sure that loads from uninitialized registers are detected from the control plane. in this case rule blob auto-zeroes registers. Thus the explicit zeroing is not needed anymore. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/netfilter/nf_tables_core.c b/net/netfilter/nf_tables_core.c index a48d5f0e2f3e1..75598520b0fa0 100644 --- a/net/netfilter/nf_tables_core.c +++ b/net/netfilter/nf_tables_core.c @@ -256,7 +256,7 @@ nft_do_chain(struct nft_pktinfo *pkt, void *priv) const struct net *net = nft_net(pkt); const struct nft_expr *expr, *last; const struct nft_rule_dp *rule; - struct nft_regs regs = {}; + struct nft_regs regs; unsigned int stackptr = 0; struct nft_jumpstack jumpstack[NFT_JUMP_STACK_SIZE]; bool genbit = READ_ONCE(net->nft.gencursor);