From: Greg Kroah-Hartman Date: Wed, 12 Sep 2018 19:14:00 +0000 (+0200) Subject: 4.18-stable patches X-Git-Tag: v4.4.156~19 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c893834334aaf71706f14f7a36030d87d47b4751;p=thirdparty%2Fkernel%2Fstable-queue.git 4.18-stable patches added patches: debugobjects-make-stack-check-warning-more-informative.patch --- diff --git a/queue-4.18/debugobjects-make-stack-check-warning-more-informative.patch b/queue-4.18/debugobjects-make-stack-check-warning-more-informative.patch new file mode 100644 index 00000000000..df2e3b70da2 --- /dev/null +++ b/queue-4.18/debugobjects-make-stack-check-warning-more-informative.patch @@ -0,0 +1,54 @@ +From fc91a3c4c27acdca0bc13af6fbb68c35cfd519f2 Mon Sep 17 00:00:00 2001 +From: "Joel Fernandes (Google)" +Date: Mon, 23 Jul 2018 14:25:31 -0700 +Subject: debugobjects: Make stack check warning more informative + +From: Joel Fernandes (Google) + +commit fc91a3c4c27acdca0bc13af6fbb68c35cfd519f2 upstream. + +While debugging an issue debugobject tracking warned about an annotation +issue of an object on stack. It turned out that the issue was due to the +object in concern being on a different stack which was due to another +issue. + +Thomas suggested to print the pointers and the location of the stack for +the currently running task. This helped to figure out that the object was +on the wrong stack. + +As this is general useful information for debugging similar issues, make +the error message more informative by printing the pointers. + +[ tglx: Massaged changelog ] + +Signed-off-by: Joel Fernandes (Google) +Signed-off-by: Thomas Gleixner +Acked-by: Waiman Long +Acked-by: Yang Shi +Cc: kernel-team@android.com +Cc: Arnd Bergmann +Cc: astrachan@google.com +Link: https://lkml.kernel.org/r/20180723212531.202328-1-joel@joelfernandes.org +Signed-off-by: Greg Kroah-Hartman + +--- + lib/debugobjects.c | 7 +++++-- + 1 file changed, 5 insertions(+), 2 deletions(-) + +--- a/lib/debugobjects.c ++++ b/lib/debugobjects.c +@@ -360,9 +360,12 @@ static void debug_object_is_on_stack(voi + + limit++; + if (is_on_stack) +- pr_warn("object is on stack, but not annotated\n"); ++ pr_warn("object %p is on stack %p, but NOT annotated.\n", addr, ++ task_stack_page(current)); + else +- pr_warn("object is not on stack, but annotated\n"); ++ pr_warn("object %p is NOT on stack %p, but annotated.\n", addr, ++ task_stack_page(current)); ++ + WARN_ON(1); + } + diff --git a/queue-4.18/series b/queue-4.18/series index c28a35b46e9..90d88505cd3 100644 --- a/queue-4.18/series +++ b/queue-4.18/series @@ -187,3 +187,4 @@ drm-amdgpu-keep-track-of-amount-of-pinned-cpu-visible-vram.patch drm-amdgpu-make-pin_size-values-atomic.patch drm-amdgpu-warn-and-update-pin_size-values-when-destroying-a-pinned-bo.patch drm-amdgpu-don-t-warn-on-destroying-a-pinned-bo.patch +debugobjects-make-stack-check-warning-more-informative.patch