From: Christopher Faulet <cfaulet@haproxy.com>
Date: Wed, 17 May 2023 07:40:14 +0000 (+0200)
Subject: CLEANUP: fcgi-app; Remove useless assignment to NULL
X-Git-Tag: v2.8-dev12~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c8a7bb16b7f0511bfdbf1ef3b03e369d518e8fac;p=thirdparty%2Fhaproxy.git

CLEANUP: fcgi-app; Remove useless assignment to NULL

When the fcgi configuration is checked and fcgi rules are created, a useless
assignment to NULL is reported by Covertiy. Let's remove it.

This patch should fix the coverity report #2161.
---

diff --git a/src/fcgi-app.c b/src/fcgi-app.c
index e0f3232f9c..16c3c81bb5 100644
--- a/src/fcgi-app.c
+++ b/src/fcgi-app.c
@@ -270,7 +270,6 @@ static int fcgi_flt_check(struct proxy *px, struct flt_conf *fconf)
 			LIST_APPEND(&fcgi_conf->param_rules, &rule->list);
 		else /* FCGI_RULE_PASS_HDR/FCGI_RULE_HIDE_HDR */
 			LIST_APPEND(&fcgi_conf->hdr_rules, &rule->list);
-		rule = NULL;
 	}
 	return 0;