From: drh <drh@noemail.net>
Date: Sat, 16 Feb 2013 02:41:01 +0000 (+0000)
Subject: Fix an unsafe VM register deallocation.
X-Git-Tag: version-3.7.16~42
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c8ac0d16492631eb7ad59219f20564353800f20c;p=thirdparty%2Fsqlite.git

Fix an unsafe VM register deallocation.

FossilOrigin-Name: cfba2c8dadbf1fa6f1602a327933570820a3b134
---

diff --git a/manifest b/manifest
index 003c2d122c..e5a46828f7 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Check\sfor\sa\sNULL\shandle\sprior\sto\smanually\scalling\swinClose.
-D 2013-02-15T04:21:01.777
+C Fix\san\sunsafe\sVM\sregister\sdeallocation.
+D 2013-02-16T02:41:01.780
 F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f
 F Makefile.in a48faa9e7dd7d556d84f5456eabe5825dd8a6282
 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23
@@ -174,7 +174,7 @@ F src/printf.c 4a9f882f1c1787a8b494a2987765acf9d97ac21f
 F src/random.c cd4a67b3953b88019f8cd4ccd81394a8ddfaba50
 F src/resolve.c 652ae6dc0f185b01b4536bb2fa7d878f13f0f1df
 F src/rowset.c 64655f1a627c9c212d9ab497899e7424a34222e0
-F src/select.c 7818b5c9b497499d8bd8c6d0e347a3cf67724867
+F src/select.c e1c6f6abdf9f359f4e735cb8ae11d2f359bf52a9
 F src/shell.c 266791241d7add796ccce2317977ae6c3c67d77f
 F src/sqlite.h.in 6296506a8fba279d8fa31f4abf01ab0cc92738a6
 F src/sqlite3.rc fea433eb0a59f4c9393c8e6d76a6e2596b1fe0c0
@@ -1034,7 +1034,7 @@ F tool/vdbe-compress.tcl f12c884766bd14277f4fcedcae07078011717381
 F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4
 F tool/warnings.sh fbc018d67fd7395f440c28f33ef0f94420226381
 F tool/win/sqlite.vsix 97894c2790eda7b5bce3cc79cb2a8ec2fde9b3ac
-P 82952d08f3e3aa80a7f51e80dbc89742cb4a09f0
-R 1a81a87cce363420c7383bdc29f10671
-U mistachkin
-Z 6e06285ee204b9b14328949d07dc3790
+P 843e1c543aabab8cd62f28742d5818887d36bcb7
+R cbf020f2dfe84836eeb7827fde2edff0
+U drh
+Z a30ad478221935586b899d8baf64a9ed
diff --git a/manifest.uuid b/manifest.uuid
index fd8b6d4e7a..9d4a6ac1bf 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-843e1c543aabab8cd62f28742d5818887d36bcb7
\ No newline at end of file
+cfba2c8dadbf1fa6f1602a327933570820a3b134
\ No newline at end of file
diff --git a/src/select.c b/src/select.c
index 2e778a57d5..7e2bed434e 100644
--- a/src/select.c
+++ b/src/select.c
@@ -2366,7 +2366,8 @@ static int multiSelectOrderBy(
   }else{
     int nExpr = p->pEList->nExpr;
     assert( nOrderBy>=nExpr || db->mallocFailed );
-    regPrev = sqlite3GetTempRange(pParse, nExpr+1);
+    regPrev = pParse->nMem+1;
+    pParse->nMem += nExpr+1;
     sqlite3VdbeAddOp2(v, OP_Integer, 0, regPrev);
     pKeyDup = sqlite3DbMallocZero(db,
                   sizeof(*pKeyDup) + nExpr*(sizeof(CollSeq*)+1) );
@@ -2548,12 +2549,6 @@ static int multiSelectOrderBy(
   sqlite3VdbeChangeP5(v, OPFLAG_PERMUTE);
   sqlite3VdbeAddOp3(v, OP_Jump, addrAltB, addrAeqB, addrAgtB);
 
-  /* Release temporary registers
-  */
-  if( regPrev ){
-    sqlite3ReleaseTempRange(pParse, regPrev, nOrderBy+1);
-  }
-
   /* Jump to the this point in order to terminate the query.
   */
   sqlite3VdbeResolveLabel(v, labelEnd);