From: Zilin Guan Date: Fri, 23 May 2025 11:47:17 +0000 (+0000) Subject: tipc: use kfree_sensitive() for aead cleanup X-Git-Tag: v6.16-rc1~132^2~16 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c8ef20fe7274c5766a317f9193b70bed717b6b3d;p=thirdparty%2Flinux.git tipc: use kfree_sensitive() for aead cleanup The tipc_aead_free() function currently uses kfree() to release the aead structure. However, this structure contains sensitive information, such as key's SALT value, which should be securely erased from memory to prevent potential leakage. To enhance security, replace kfree() with kfree_sensitive() when freeing the aead structure. This change ensures that sensitive data is explicitly cleared before memory deallocation, aligning with the approach used in tipc_aead_init() and adhering to best practices for handling confidential information. Signed-off-by: Zilin Guan Reviewed-by: Tung Nguyen Link: https://patch.msgid.link/20250523114717.4021518-1-zilin@seu.edu.cn Signed-off-by: Jakub Kicinski --- diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c index 8584893b47851..f4cfe88670f55 100644 --- a/net/tipc/crypto.c +++ b/net/tipc/crypto.c @@ -425,7 +425,7 @@ static void tipc_aead_free(struct rcu_head *rp) } free_percpu(aead->tfm_entry); kfree_sensitive(aead->key); - kfree(aead); + kfree_sensitive(aead); } static int tipc_aead_users(struct tipc_aead __rcu *aead)