From: Ian Molton Date: Fri, 8 Dec 2017 12:10:32 +0000 (+0100) Subject: brcmfmac: remove unnecessary call to brcmf_sdiod_set_backplane_window() X-Git-Tag: v4.16-rc1~123^2~329^2~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c900072bd6faff089aa4fb7b19136a2a0fe3baf0;p=thirdparty%2Fkernel%2Flinux.git brcmfmac: remove unnecessary call to brcmf_sdiod_set_backplane_window() All functions that might require the window address changing call brcmf_sdiod_set_backplane_window() prior to access. Thus resetting the window is not required. Signed-off-by: Ian Molton [arend: corrected the driver prefix in the subject] Signed-off-by: Arend van Spriel Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c index 5fcd19346b84b..f8b47c1f4bcd6 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c @@ -723,11 +723,6 @@ brcmf_sdiod_ramrw(struct brcmf_sdio_dev *sdiodev, bool write, u32 address, dev_kfree_skb(pkt); - /* Return the window to backplane enumeration space for core access */ - if (brcmf_sdiod_set_backplane_window(sdiodev, sdiodev->sbwad)) - brcmf_err("FAILED to set window back to 0x%x\n", - sdiodev->sbwad); - sdio_release_host(sdiodev->func[1]); return err;