From: b1-luettje <53084931+b1-luettje@users.noreply.github.com>
Date: Sat, 31 Aug 2019 00:00:55 +0000 (+0200)
Subject: :sparkles: Allow disabling Google fonts in ReDoc (#481)
X-Git-Tag: 0.37.0~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c90c4fb6c1ed5d8d8f32dd2e31a022a2bb4aca41;p=thirdparty%2Ffastapi%2Ffastapi.git

:sparkles: Allow disabling Google fonts in ReDoc (#481)
---

diff --git a/fastapi/openapi/docs.py b/fastapi/openapi/docs.py
index f6c996b4bf..024ae269fa 100644
--- a/fastapi/openapi/docs.py
+++ b/fastapi/openapi/docs.py
@@ -56,6 +56,7 @@ def get_redoc_html(
     title: str,
     redoc_js_url: str = "https://cdn.jsdelivr.net/npm/redoc@next/bundles/redoc.standalone.js",
     redoc_favicon_url: str = "https://fastapi.tiangolo.com/img/favicon.png",
+    with_google_fonts: bool = True,
 ) -> HTMLResponse:
     html = f"""
     <!DOCTYPE html>
@@ -65,7 +66,12 @@ def get_redoc_html(
     <!-- needed for adaptive design -->
     <meta charset="utf-8"/>
     <meta name="viewport" content="width=device-width, initial-scale=1">
+    """
+    if with_google_fonts:
+        html += """
     <link href="https://fonts.googleapis.com/css?family=Montserrat:300,400,700|Roboto:300,400,700" rel="stylesheet">
+    """
+    html += f"""
     <link rel="shortcut icon" href="{redoc_favicon_url}">
     <!--
     ReDoc doesn't change outer page styles
diff --git a/tests/test_local_docs.py b/tests/test_local_docs.py
index 332fd838a0..0ef7770309 100644
--- a/tests/test_local_docs.py
+++ b/tests/test_local_docs.py
@@ -54,3 +54,14 @@ def test_strings_in_custom_redoc():
     body_content = html.body.decode()
     assert redoc_js_url in body_content
     assert redoc_favicon_url in body_content
+
+
+def test_google_fonts_in_generated_redoc():
+    body_with_google_fonts = get_redoc_html(
+        openapi_url="/docs", title="title"
+    ).body.decode()
+    assert "fonts.googleapis.com" in body_with_google_fonts
+    body_without_google_fonts = get_redoc_html(
+        openapi_url="/docs", title="title", with_google_fonts=False
+    ).body.decode()
+    assert "fonts.googleapis.com" not in body_without_google_fonts
