From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 15 Jun 2022 23:35:44 +0000 (+0000)
Subject: relative_url(): fix incorrect condition
X-Git-Tag: v2.37.0-rc1~7^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c918f5c1ab0c4dec916b747916236ca0d3655be5;p=thirdparty%2Fgit.git

relative_url(): fix incorrect condition

In 63e95beb085c (submodule: port resolve_relative_url from shell to C,
2016-04-15), we added a loop over `url` where we are looking for `../`
or `./` components.

The loop condition we used is the pointer `url` itself, which is clearly
not what we wanted.

Pointed out by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/remote.c b/remote.c
index 9b9bbfe80e..bded6acbfe 100644
--- a/remote.c
+++ b/remote.c
@@ -2846,7 +2846,7 @@ char *relative_url(const char *remote_url, const char *url,
 	 * When the url starts with '../', remove that and the
 	 * last directory in remoteurl.
 	 */
-	while (url) {
+	while (*url) {
 		if (starts_with_dot_dot_slash_native(url)) {
 			url += 3;
 			colonsep |= chop_last_dir(&remoteurl, is_relative);