From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Tue, 30 Aug 2022 15:40:03 +0000 (-0400)
Subject: bcachefs: Don't leak lock pcpu counts memory
X-Git-Tag: v6.7-rc1~201^2~803
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c919f53f3bcba3598fc6ce1ee5c5aed75d0834b7;p=thirdparty%2Fkernel%2Flinux.git

bcachefs: Don't leak lock pcpu counts memory

This fixes a small memory leak.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/btree_key_cache.c b/fs/bcachefs/btree_key_cache.c
index 127cb6edaff5a..7349c70f84451 100644
--- a/fs/bcachefs/btree_key_cache.c
+++ b/fs/bcachefs/btree_key_cache.c
@@ -238,8 +238,6 @@ btree_key_cache_create(struct bch_fs *c,
 	} else {
 		if (btree_id == BTREE_ID_subvolumes)
 			six_lock_pcpu_alloc(&ck->c.lock);
-		else
-			six_lock_pcpu_free(&ck->c.lock);
 	}
 
 	ck->c.level		= 0;
@@ -688,6 +686,7 @@ static unsigned long bch2_btree_key_cache_scan(struct shrinker *shrink,
 			break;
 
 		list_del(&ck->list);
+		six_lock_pcpu_free(&ck->c.lock);
 		kmem_cache_free(bch2_key_cache, ck);
 		atomic_long_dec(&bc->nr_freed);
 		scanned++;