From: Yangtao Li Date: Mon, 20 Mar 2023 17:31:36 +0000 (+0800) Subject: f2fs: remove else in f2fs_write_cache_pages() X-Git-Tag: v6.4-rc1~138^2~39 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c948be797da8ddbb1ec2f5cccad1c8629c69db79;p=thirdparty%2Flinux.git f2fs: remove else in f2fs_write_cache_pages() As Christoph Hellwig point out: Please avoid the else by doing the goto in the branch. Signed-off-by: Yangtao Li Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index bf51e6e4eb64f..fa931fb768e79 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -3123,12 +3123,9 @@ continue_unlock: } if (folio_test_writeback(folio)) { - if (wbc->sync_mode != WB_SYNC_NONE) - f2fs_wait_on_page_writeback( - &folio->page, - DATA, true, true); - else + if (wbc->sync_mode == WB_SYNC_NONE) goto continue_unlock; + f2fs_wait_on_page_writeback(&folio->page, DATA, true, true); } if (!folio_clear_dirty_for_io(folio))