From: drh <drh@noemail.net>
Date: Wed, 27 Nov 2013 04:22:27 +0000 (+0000)
Subject: Lower the threshold for using skip-scan from 50 to 18, based on experiments
X-Git-Tag: version-3.8.2~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c964c39fb02e9495ae3783f79865aae5df0d487d;p=thirdparty%2Fsqlite.git

Lower the threshold for using skip-scan from 50 to 18, based on experiments
that show that 18 is the approximate break-even point for a variety of
schemas.

FossilOrigin-Name: 83c0bb9913838d18ba355033afde6e38b4690842
---

diff --git a/manifest b/manifest
index 4d6b73bdbd..2854113f03 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Avoid\susing\sthe\sGetVersionEx\sfunctions\sif\sthey\sare\sconsidered\sdeprecated.
-D 2013-11-27T04:00:32.164
+C Lower\sthe\sthreshold\sfor\susing\sskip-scan\sfrom\s50\sto\s18,\sbased\son\sexperiments\nthat\sshow\sthat\s18\sis\sthe\sapproximate\sbreak-even\spoint\sfor\sa\svariety\sof\nschemas.
+D 2013-11-27T04:22:27.199
 F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f
 F Makefile.in e1a9b4258bbde53f5636f4e238c65b7e11459e2b
 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23
@@ -293,7 +293,7 @@ F src/vtab.c 21b932841e51ebd7d075e2d0ad1415dce8d2d5fd
 F src/wal.c 7dc3966ef98b74422267e7e6e46e07ff6c6eb1b4
 F src/wal.h df01efe09c5cb8c8e391ff1715cca294f89668a4
 F src/walker.c e9e593d5bb798c3e67fc3893dfe7055c9e7d8d74
-F src/where.c e558bfa67009ab7de08a7a1960ae0dd443241cdd
+F src/where.c e0a9909a58eee7dcde1d1bd5cf6381b0dbc83389
 F src/whereInt.h 96a75c61f1d2b9d4a8e4bb17d89deb0cf7cba358
 F test/8_3_names.test ebbb5cd36741350040fd28b432ceadf495be25b2
 F test/aggerror.test a867e273ef9e3d7919f03ef4f0e8c0d2767944f2
@@ -1145,7 +1145,7 @@ F tool/vdbe-compress.tcl f12c884766bd14277f4fcedcae07078011717381
 F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4
 F tool/warnings.sh d1a6de74685f360ab718efda6265994b99bbea01
 F tool/win/sqlite.vsix 030f3eeaf2cb811a3692ab9c14d021a75ce41fff
-P 1ae4915d4d08ee5ce526c04d1d0cda1078641793 0ea9e4722be10221c99cce5bc48d13c7b34e739f
-R 1408bb35546f8304605f0cd70b3a2cef
-U mistachkin
-Z 11a83dbec42d946c53dc2adfcd9de746
+P afdca29966805ed0d49fd61a161eb3a3919b5963
+R 7f77bcc3aede19c7431a578762bf35fa
+U drh
+Z 4656cf413e484f30bbac5ec324b067a0
diff --git a/manifest.uuid b/manifest.uuid
index 5dcbdd9cc3..ad77d07941 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-afdca29966805ed0d49fd61a161eb3a3919b5963
\ No newline at end of file
+83c0bb9913838d18ba355033afde6e38b4690842
\ No newline at end of file
diff --git a/src/where.c b/src/where.c
index 101ca1a7c6..7ec6cfaae7 100644
--- a/src/where.c
+++ b/src/where.c
@@ -3921,12 +3921,14 @@ static int whereLoopAddBtreeIndex(
 
   /* Consider using a skip-scan if there are no WHERE clause constraints
   ** available for the left-most terms of the index, and if the average
-  ** number of repeats in the left-most terms is at least 50.
+  ** number of repeats in the left-most terms is at least 18.  The magic
+  ** number 18 was found by experimentation to be the payoff point where
+  ** skip-scan become faster than a full-scan.
   */
   if( pTerm==0
    && saved_nEq==saved_nSkip
    && saved_nEq+1<pProbe->nKeyCol
-   && pProbe->aiRowEst[saved_nEq+1]>50  /* TUNING: Minimum for skip-scan */
+   && pProbe->aiRowEst[saved_nEq+1]>=18  /* TUNING: Minimum for skip-scan */
   ){
     LogEst nIter;
     pNew->u.btree.nEq++;