From: tblume <Thomas.Blume@suse.com>
Date: Wed, 21 Jun 2017 17:29:58 +0000 (+0200)
Subject: only check signature job error if signature job exists (#6118)
X-Git-Tag: v234~119
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c9fb8c7c4a748a9205629f08d16afbb61d8e875b;p=thirdparty%2Fsystemd.git

only check signature job error if signature job exists (#6118)

otherwise it will segfault when accessing signature jobs error status
---

diff --git a/src/import/pull-raw.c b/src/import/pull-raw.c
index a15eac1f1fe..974e42d7ce3 100644
--- a/src/import/pull-raw.c
+++ b/src/import/pull-raw.c
@@ -498,7 +498,7 @@ static void raw_pull_job_on_finished(PullJob *j) {
         if (!raw_pull_is_done(i))
                 return;
 
-        if (i->checksum_job->style == VERIFICATION_PER_DIRECTORY && i->signature_job->error != 0) {
+        if (i->signature_job && i->checksum_job->style == VERIFICATION_PER_DIRECTORY && i->signature_job->error != 0) {
                 log_error_errno(j->error, "Failed to retrieve signature file, cannot verify. (Try --verify=no?)");
 
                 r = i->signature_job->error;
diff --git a/src/import/pull-tar.c b/src/import/pull-tar.c
index d4b599ba951..16ce9016502 100644
--- a/src/import/pull-tar.c
+++ b/src/import/pull-tar.c
@@ -315,7 +315,7 @@ static void tar_pull_job_on_finished(PullJob *j) {
         if (!tar_pull_is_done(i))
                 return;
 
-        if (i->checksum_job->style == VERIFICATION_PER_DIRECTORY && i->signature_job->error != 0) {
+        if (i->signature_job && i->checksum_job->style == VERIFICATION_PER_DIRECTORY && i->signature_job->error != 0) {
                 log_error_errno(j->error, "Failed to retrieve signature file, cannot verify. (Try --verify=no?)");
 
                 r = i->signature_job->error;