From: Dmitry Torokhov Date: Fri, 18 Nov 2022 16:43:47 +0000 (-0800) Subject: MIPS: DTS: CI20: fix reset line polarity of the ethernet controller X-Git-Tag: v6.2-rc1~200^2~20 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ca637c0ece144ce62ec8ef75dc127bcccd4f442a;p=thirdparty%2Fkernel%2Flinux.git MIPS: DTS: CI20: fix reset line polarity of the ethernet controller The reset line is called PWRST#, annotated as "active low" in the binding documentation, and is driven low and then high by the driver to reset the chip. However in device tree for CI20 board it was incorrectly marked as "active high". Fix it. Because (as far as I know) the ci20.dts is always built in the kernel I elected not to also add a quirk to gpiolib to force the polarity there. Fixes: db49ca38579d ("net: davicom: dm9000: switch to using gpiod API") Reported-by: Paul Cercueil Signed-off-by: Dmitry Torokhov Acked-by: Paul Cercueil Signed-off-by: Thomas Bogendoerfer --- diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts index 37c46720c719a..f38c39572a9e8 100644 --- a/arch/mips/boot/dts/ingenic/ci20.dts +++ b/arch/mips/boot/dts/ingenic/ci20.dts @@ -438,7 +438,7 @@ ingenic,nemc-tAW = <50>; ingenic,nemc-tSTRV = <100>; - reset-gpios = <&gpf 12 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpf 12 GPIO_ACTIVE_LOW>; vcc-supply = <ð0_power>; interrupt-parent = <&gpe>;