From: John Ogness <john.ogness@linutronix.de>
Date: Thu, 25 May 2023 09:31:54 +0000 (+0206)
Subject: serial: 8250: lock port for stop_rx() in omap8250_irq()
X-Git-Tag: v6.5-rc1~74^2~41
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ca73a892c5bec4b08a2fa22b3015e98ed905abb7;p=thirdparty%2Fkernel%2Flinux.git

serial: 8250: lock port for stop_rx() in omap8250_irq()

The uarts_ops stop_rx() callback expects that the port->lock is
taken and interrupts are disabled.

Fixes: 1fe0e1fa3209 ("serial: 8250_omap: Handle optional overrun-throttle-ms property")
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20230525093159.223817-4-john.ogness@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
index fbca0692aa51b..c17d98161d5ef 100644
--- a/drivers/tty/serial/8250/8250_omap.c
+++ b/drivers/tty/serial/8250/8250_omap.c
@@ -658,7 +658,9 @@ static irqreturn_t omap8250_irq(int irq, void *dev_id)
 
 		up->ier = port->serial_in(port, UART_IER);
 		if (up->ier & (UART_IER_RLSI | UART_IER_RDI)) {
+			spin_lock(&port->lock);
 			port->ops->stop_rx(port);
+			spin_unlock(&port->lock);
 		} else {
 			/* Keep restarting the timer until
 			 * the input overrun subsides.