From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Tue, 26 Nov 2024 09:25:11 +0000 (+0100)
Subject: improve error messages a bit
X-Git-Tag: dnsdist-1.9.8^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ca76b361e4757d8c90ec1d0839faa7347d59936f;p=thirdparty%2Fpdns.git

improve error messages a bit

(cherry picked from commit 8b9d0180585096d2c0ecf959aff1569edc90502b)
---

diff --git a/pdns/dnsdistdist/dnsdist-metrics.cc b/pdns/dnsdistdist/dnsdist-metrics.cc
index d47236ea8b..a3cbef1af9 100644
--- a/pdns/dnsdistdist/dnsdist-metrics.cc
+++ b/pdns/dnsdistdist/dnsdist-metrics.cc
@@ -203,7 +203,7 @@ std::variant<uint64_t, Error> incrementCustomCounter(const std::string_view& nam
     metric->second.d_value += step;
     return metric->second.d_value.load();
   }
-  return std::string("Unable to increment custom metric '") + std::string(name) + "': no such metric";
+  return std::string("Unable to increment custom metric '") + std::string(name) + "': no such counter";
 }
 
 std::variant<uint64_t, Error> decrementCustomCounter(const std::string_view& name, uint64_t step)
@@ -214,7 +214,7 @@ std::variant<uint64_t, Error> decrementCustomCounter(const std::string_view& nam
     metric->second.d_value -= step;
     return metric->second.d_value.load();
   }
-  return std::string("Unable to decrement custom metric '") + std::string(name) + "': no such metric";
+  return std::string("Unable to decrement custom metric '") + std::string(name) + "': no such counter";
 }
 
 std::variant<double, Error> setCustomGauge(const std::string_view& name, const double value)
@@ -226,7 +226,7 @@ std::variant<double, Error> setCustomGauge(const std::string_view& name, const d
     return value;
   }
 
-  return std::string("Unable to set metric '") + std::string(name) + "': no such metric";
+  return std::string("Unable to set metric '") + std::string(name) + "': no such gauge";
 }
 
 std::variant<double, Error> getCustomMetric(const std::string_view& name)