From: Willy Tarreau <w@1wt.eu>
Date: Fri, 20 Dec 2019 16:26:27 +0000 (+0100)
Subject: BUG/MINOR: state-file: do not leak memory on parse errors
X-Git-Tag: v2.2-dev1~159
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ca7a5af664504cbe13240e5bc538efbcef4f6162;p=thirdparty%2Fhaproxy.git

BUG/MINOR: state-file: do not leak memory on parse errors

Issue #417 reports a possible memory leak in the state-file loading code.
There's one such place in the loop which corresponds to parsing errors
where the curreently allocated line is not freed when dropped. In any
case this is very minor in that no more than the file's length may be
lost in the worst case, considering that the whole file is kept anyway
in case of success. This fix addresses this.

It should be backported to 2.1.
---

diff --git a/src/server.c b/src/server.c
index 466da441b4..6212a420ed 100644
--- a/src/server.c
+++ b/src/server.c
@@ -3616,7 +3616,7 @@ void apply_server_state(void)
 
 			srv_state_parse_line(mybuf, global_file_version, params, srv_params);
 			if (params[0] == NULL)
-				continue;
+				goto nextline;
 
 			/* bkname */
 			bkname = params[1];