From: Chen Qun <kuhn.chenqun@huawei.com>
Date: Thu, 27 Aug 2020 11:03:10 +0000 (+0800)
Subject: hw/intc: fix default registers value in exynos4210_combiner_read()
X-Git-Tag: v5.2.0-rc0~146^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cad2197ba10f5634b87ded155ad85e060f6926eb;p=thirdparty%2Fqemu.git

hw/intc: fix default registers value in exynos4210_combiner_read()

Clang static code analyzer show warning:
hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never read
        val = s->reg_set[offset >> 2];

The default register return value should be return 'val'.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20200827110311.164316-10-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---

diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c
index b8561e41803..59dd27fb16e 100644
--- a/hw/intc/exynos4210_combiner.c
+++ b/hw/intc/exynos4210_combiner.c
@@ -229,7 +229,6 @@ exynos4210_combiner_read(void *opaque, hwaddr offset, unsigned size)
                     TARGET_FMT_plx "offset\n", offset);
         }
         val = s->reg_set[offset >> 2];
-        return 0;
     }
     return val;
 }