From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Wed, 29 Jan 2025 08:17:46 +0000 (+0200)
Subject: imap-login: Fix leaking settings instance memory
X-Git-Tag: 2.4.1~273
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cafb216e2c2537e29436afcecf6d6913611cebea;p=thirdparty%2Fdovecot%2Fcore.git

imap-login: Fix leaking settings instance memory
---

diff --git a/src/imap-login/imap-login-client.c b/src/imap-login/imap-login-client.c
index f7b76e8327..90bc70127c 100644
--- a/src/imap-login/imap-login-client.c
+++ b/src/imap-login/imap-login-client.c
@@ -387,6 +387,7 @@ static int imap_client_create(struct client *client)
 	if (set_instance == NULL) {
 		set_instance = settings_instance_new(
 			master_service_get_settings_root(master_service));
+		imap_client->set_instance = set_instance;
 		event_set_ptr(client->event, SETTINGS_EVENT_INSTANCE, set_instance);
 	}
 
@@ -419,6 +420,7 @@ static void imap_client_destroy(struct client *client)
 	}
 
 	settings_free(imap_client->set);
+	settings_instance_free(&imap_client->set_instance);
 	i_free_and_null(imap_client->proxy_backend_capability);
 	imap_parser_unref(&imap_client->parser);
 }
diff --git a/src/imap-login/imap-login-client.h b/src/imap-login/imap-login-client.h
index d23aebab0f..a62d30445a 100644
--- a/src/imap-login/imap-login-client.h
+++ b/src/imap-login/imap-login-client.h
@@ -55,6 +55,7 @@ struct imap_client {
 	struct client common;
 
 	const struct imap_login_settings *set;
+	struct settings_instance *set_instance;
 	struct imap_parser *parser;
 	char *proxy_backend_capability;