From: Eric Sandeen Date: Mon, 19 Sep 2016 06:06:57 +0000 (+1000) Subject: xfs_quota: un-flag non-foreign-capable commands X-Git-Tag: v4.8.0-rc2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cb3567186087b9f8993ebd57186f13f3ad0a0ead;p=thirdparty%2Fxfsprogs-dev.git xfs_quota: un-flag non-foreign-capable commands The off command calls XFS_QUOTAOFF / Q_XQUOTAOFF, which calls quota_disable in the kernel, which returns ENOSYS if the ->quota_enable quota op doesn't exist - and it does not exist on any non-xfs filesystems. We could get clever if we wanted it, and send Q_QUOTAOFF instead for foreign filesystems, but for now it's broken so just remove the flag. The free command relies on XFS_IOC_FSGEOMETRY_V1, so unflag it as well. Signed-off-by: Eric Sandeen Reviewed-by: Bill O'Donnell --- diff --git a/quota/free.c b/quota/free.c index b9be9547d..3c8a5ce1b 100644 --- a/quota/free.c +++ b/quota/free.c @@ -372,7 +372,6 @@ free_init(void) free_cmd.args = _("[-bir] [-hn] [-f file]"); free_cmd.oneline = _("show free and used counts for blocks and inodes"); free_cmd.help = free_help; - free_cmd.flags = CMD_FLAG_FOREIGN_OK; add_command(&free_cmd); } diff --git a/quota/state.c b/quota/state.c index 05e4ec529..09dfa7053 100644 --- a/quota/state.c +++ b/quota/state.c @@ -584,7 +584,6 @@ state_init(void) off_cmd.args = _("[-gpu] [-v]"); off_cmd.oneline = _("permanently switch quota off for a path"); off_cmd.help = off_help; - off_cmd.flags = CMD_FLAG_FOREIGN_OK; state_cmd.name = "state"; state_cmd.cfunc = state_f;