From: Karel Zak <kzak@redhat.com>
Date: Wed, 15 May 2019 15:25:04 +0000 (+0200)
Subject: libmount: fix memory leak on error [coverity scan]
X-Git-Tag: v2.34-rc2~62
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cb400752a4114c0c904c20253ed5ee68c11dc326;p=thirdparty%2Futil-linux.git

libmount: fix memory leak on error [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/libmount/src/context_umount.c b/libmount/src/context_umount.c
index 7c5893ae6c..999cdb0166 100644
--- a/libmount/src/context_umount.c
+++ b/libmount/src/context_umount.c
@@ -574,9 +574,10 @@ static int evaluate_permissions(struct libmnt_context *cxt)
 
 		curr_user = mnt_get_username(getuid());
 
-		if (!mnt_context_switch_ns(cxt, ns_old))
+		if (!mnt_context_switch_ns(cxt, ns_old)) {
+			free(curr_user);
 			return -MNT_ERR_NAMESPACE;
-
+		}
 		if (!curr_user) {
 			DBG(CXT, ul_debugobj(cxt, "umount %s: cannot "
 				"convert %d to username", tgt, getuid()));