From: Christopher Faulet <cfaulet@haproxy.com>
Date: Wed, 17 May 2023 07:25:32 +0000 (+0200)
Subject: CLEANUP: check; Remove some useless assignments to NULL
X-Git-Tag: v2.8-dev12~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cb76030356b5da5a5a5b253a5d7c9742266071d5;p=thirdparty%2Fhaproxy.git

CLEANUP: check; Remove some useless assignments to NULL

In process_chk_conn(), some assignments to NULL are useless and are reported
by Coverity as unused value. while it is harmless, these assignments can be
removed.

This patch should fix the coverity report #2158.
---

diff --git a/src/check.c b/src/check.c
index 86cd5963c7..a440185daa 100644
--- a/src/check.c
+++ b/src/check.c
@@ -1242,7 +1242,6 @@ struct task *process_chk_conn(struct task *t, void *context, unsigned int state)
 			if (check->state & CHK_ST_CLOSE_CONN) {
 				TRACE_DEVEL("closing current connection", CHK_EV_TASK_WAKE|CHK_EV_HCHK_RUN, check);
 				check->state &= ~CHK_ST_CLOSE_CONN;
-				conn = NULL;
 				if (!sc_reset_endp(check->sc)) {
 					/* error will be handled by tcpcheck_main().
 					 * On success, remove all flags except SE_FL_DETACHED
@@ -1277,8 +1276,7 @@ struct task *process_chk_conn(struct task *t, void *context, unsigned int state)
 
 	if (sc) {
 		sc_destroy(sc);
-		sc = check->sc = NULL;
-		conn = NULL;
+		check->sc = NULL;
 	}
 
 	if (check->sess != NULL) {