From: Simon Marchi Date: Fri, 12 Apr 2024 17:51:54 +0000 (-0400) Subject: gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension X-Git-Tag: gdb-15-branchpoint~364 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cbb97c5be367123a00846d4dacb6a042fff87901;p=thirdparty%2Fbinutils-gdb.git gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension When building with clang 18, I see: CXX aarch64-linux-tdep.o /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1299:26: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension] 1299 | gdb_byte za_zeroed[za_bytes]; | ^~~~~~~~ /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1299:26: note: read of non-const variable 'za_bytes' is not allowed in a constant expression /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1282:10: note: declared here 1282 | size_t za_bytes = std::pow (sve_vl_from_vg (svg), 2); | ^ Since we are using VLAs right now, that warning doesn't make sense for us. add `-Wno-vla-cxx-extension` to the list of warning flags we try to enable. If we ever choose to disallow VLAs, we can remove that flag. Change-Id: Ie41feafc50c343f6e75333d4f836ce32fbeb6d8c --- diff --git a/gdb/configure b/gdb/configure index a77e3e27332..c3d5cf7ed63 100755 --- a/gdb/configure +++ b/gdb/configure @@ -31179,6 +31179,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wredundant-move \ -Wmissing-declarations \ -Wstrict-null-sentinel \ +-Wno-vla-cxx-extension \ " # The -Wmissing-prototypes flag will be accepted by GCC, but results diff --git a/gdbserver/configure b/gdbserver/configure index b85db9cd49d..026d250cc73 100755 --- a/gdbserver/configure +++ b/gdbserver/configure @@ -13706,6 +13706,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wredundant-move \ -Wmissing-declarations \ -Wstrict-null-sentinel \ +-Wno-vla-cxx-extension \ " # The -Wmissing-prototypes flag will be accepted by GCC, but results diff --git a/gdbsupport/configure b/gdbsupport/configure index b45f12de45b..ae991250ce4 100755 --- a/gdbsupport/configure +++ b/gdbsupport/configure @@ -14179,6 +14179,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wredundant-move \ -Wmissing-declarations \ -Wstrict-null-sentinel \ +-Wno-vla-cxx-extension \ " # The -Wmissing-prototypes flag will be accepted by GCC, but results diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4 index bdac8b3e7d2..d12bccbd3fb 100644 --- a/gdbsupport/warning.m4 +++ b/gdbsupport/warning.m4 @@ -52,6 +52,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wredundant-move \ -Wmissing-declarations \ -Wstrict-null-sentinel \ +-Wno-vla-cxx-extension \ " # The -Wmissing-prototypes flag will be accepted by GCC, but results