From: Shahab Vahedi Date: Mon, 18 Jul 2022 17:44:06 +0000 (-0400) Subject: dwfl_get_debuginfod_client: add dummy parameter for --disable-libdebuginfod X-Git-Tag: elfutils-0.188~56 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cc2d459520de4f6680a0e9e9356d014356bd4718;p=thirdparty%2Felfutils.git dwfl_get_debuginfod_client: add dummy parameter for --disable-libdebuginfod Since the stub version of "dwfl_get_debuginfod_client" doesn't name its parameter, building elfuitls fails on a system with gcc 10.2.1: ----------------------------------------------------------------------------- $ ./configure ... --disable-libdebuginfod $ make Making all in libdwfl CC debuginfod-client.o /src/libdwfl/debuginfod-client.c: In function 'dwfl_get_debuginfod_client': /src/libdwfl/debuginfod-client.c:145:29: error: parameter name omitted 145 | dwfl_get_debuginfod_client (Dwfl *) | ^~~~~~ make[2]: *** [Makefile:707: debuginfod-client.o] Error 1 ----------------------------------------------------------------------------- This fixes the issue by providing a name for the unused parameter. Signed-off-by: Shahab Vahedi --- diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index 6ade1afc0..75c53948d 100644 --- a/libdwfl/ChangeLog +++ b/libdwfl/ChangeLog @@ -1,3 +1,8 @@ +2022-07-18 Shahab Vahedi + + * debuginfod-client.c (dwfl_get_debuginfod_client stub): + Add a name to the sole parameter. + 2022-07-13 Mark Wielaard * debuginfod-client.c (dwfl_get_debuginfod_client): Add INTDEF. diff --git a/libdwfl/debuginfod-client.c b/libdwfl/debuginfod-client.c index 87af73a71..d581daabf 100644 --- a/libdwfl/debuginfod-client.c +++ b/libdwfl/debuginfod-client.c @@ -142,7 +142,7 @@ __libdwfl_debuginfod_init (void) #else // ENABLE_LIBDEBUGINFOD debuginfod_client * -dwfl_get_debuginfod_client (Dwfl *) +dwfl_get_debuginfod_client (Dwfl *dummy __attribute__ ((unused))) { return NULL; }