From: Mark Levedahl <mlevedahl@gmail.com>
Date: Sat, 31 May 2025 19:18:31 +0000 (-0400)
Subject: git-gui: use -profile tcl8 on encoding conversions
X-Git-Tag: v2.51.0-rc1~9^2~2^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cc41d374fa9e130cf9b89da5cbcf7694257b7df1;p=thirdparty%2Fgit.git

git-gui: use -profile tcl8 on encoding conversions

git-gui in the prior commit learned to apply -profile tcl8 when reading
files, avoiding errors on non-binary data streams whose encoding is not
utf-8. But, git-gui also consumes binary data streams (generally blobs
from commits) as the output of commands, and internally decodes this to
support various displays.

With Tcl9, errors occur in this decoding for the same reasons described
in the previous commit: basically, the underlying data may contain
extended ascii characters violating the assumption of utf-8 encoding.

This problem has a similar fix to the prior issue: we must use the tlc8
profile when converting this data to the internal unicode format. Do so,
again only on Tcl9 as Tcl8.6 does not recognize -profile, and only Tcl
9.0 makes strict the default.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---

diff --git a/git-gui.sh b/git-gui.sh
index 2c83ed5066..1ebf1e288d 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -84,6 +84,13 @@ if {[package vcompare $::tcl_version 9.0] >= 0} {
 		chan configure $f -profile tcl8
 		return $f
 	}
+	proc convertfrom args {
+		return [encoding convertfrom -profile tcl8 {*}$args]
+	}
+} else {
+	proc convertfrom args {
+		return [encoding convertfrom {*}$args]
+	}
 }
 
 ######################################################################
@@ -1543,7 +1550,7 @@ proc read_diff_index {fd after} {
 		set i [split [string range $buf_rdi $c [expr {$z1 - 2}]] { }]
 		set p [string range $buf_rdi $z1 [expr {$z2 - 1}]]
 		merge_state \
-			[encoding convertfrom utf-8 $p] \
+			[convertfrom utf-8 $p] \
 			[lindex $i 4]? \
 			[list [lindex $i 0] [lindex $i 2]] \
 			[list]
@@ -1576,7 +1583,7 @@ proc read_diff_files {fd after} {
 		set i [split [string range $buf_rdf $c [expr {$z1 - 2}]] { }]
 		set p [string range $buf_rdf $z1 [expr {$z2 - 1}]]
 		merge_state \
-			[encoding convertfrom utf-8 $p] \
+			[convertfrom utf-8 $p] \
 			?[lindex $i 4] \
 			[list] \
 			[list [lindex $i 0] [lindex $i 2]]
@@ -1599,7 +1606,7 @@ proc read_ls_others {fd after} {
 	set pck [split $buf_rlo "\0"]
 	set buf_rlo [lindex $pck end]
 	foreach p [lrange $pck 0 end-1] {
-		set p [encoding convertfrom utf-8 $p]
+		set p [convertfrom utf-8 $p]
 		if {[string index $p end] eq {/}} {
 			set p [string range $p 0 end-1]
 		}
diff --git a/lib/blame.tcl b/lib/blame.tcl
index 22c5e7a193..4477b84eae 100644
--- a/lib/blame.tcl
+++ b/lib/blame.tcl
@@ -997,7 +997,7 @@ method _showcommit {cur_w lno} {
 
 				set enc [tcl_encoding $enc]
 				if {$enc ne {}} {
-					set msg [encoding convertfrom $enc $msg]
+					set msg [convertfrom $enc $msg]
 				}
 				set msg [string trim $msg]
 			}
diff --git a/lib/commit.tcl b/lib/commit.tcl
index 5e77fd2f54..2c2f73d3af 100644
--- a/lib/commit.tcl
+++ b/lib/commit.tcl
@@ -43,9 +43,9 @@ You are currently in the middle of a merge that has not been fully completed.  Y
 
 			set enc [tcl_encoding $enc]
 			if {$enc ne {}} {
-				set msg [encoding convertfrom $enc $msg]
-				set name [encoding convertfrom $enc $name]
-				set email [encoding convertfrom $enc $email]
+				set msg [convertfrom $enc $msg]
+				set name [convertfrom $enc $name]
+				set email [convertfrom $enc $email]
 			}
 			if {$name ne {} && $email ne {}} {
 				set commit_author [list name $name email $email date $time]