From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 28 Nov 2023 15:06:30 +0000 (+0100)
Subject: qemu_command: Don't open code virPCIDeviceAddressAsString()
X-Git-Tag: v10.0.0-rc1~141
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cc9f439be922289419d360aaf20b5cb9461f4ae3;p=thirdparty%2Flibvirt.git

qemu_command: Don't open code virPCIDeviceAddressAsString()

When building a hostdev props, its PCI address is formatted via
g_strdup_printf(VIR_PCI_DEVICE_ADDRESS_FMT, ...); Well, we have a
function that does exactly that: virPCIDeviceAddressAsString().
Use the latter.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index d54149ed2d..23909dbbab 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4704,11 +4704,7 @@ qemuBuildPCIHostdevDevProps(const virDomainDef *def,
     g_autoptr(virJSONValue) props = NULL;
     virDomainHostdevSubsysPCI *pcisrc = &dev->source.subsys.u.pci;
     virDomainNetTeamingInfo *teaming;
-    g_autofree char *host = g_strdup_printf(VIR_PCI_DEVICE_ADDRESS_FMT,
-                                            pcisrc->addr.domain,
-                                            pcisrc->addr.bus,
-                                            pcisrc->addr.slot,
-                                            pcisrc->addr.function);
+    g_autofree char *host = virPCIDeviceAddressAsString(&pcisrc->addr);
     const char *failover_pair_id = NULL;
 
     /* caller has to assign proper passthrough backend type */