From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Mon, 6 Nov 2017 08:57:03 +0000 (+0200)
Subject: director: Log an error if login process sends unexpected reply to KICK* commands
X-Git-Tag: 2.2.34~236
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cca6aef9dd68005bc777717f54e9a0315a1f3759;p=thirdparty%2Fdovecot%2Fcore.git

director: Log an error if login process sends unexpected reply to KICK* commands
---

diff --git a/src/director/director.c b/src/director/director.c
index b9b1048181..70816d0b31 100644
--- a/src/director/director.c
+++ b/src/director/director.c
@@ -971,6 +971,7 @@ static void director_kill_user_callback(enum ipc_client_cmd_state state,
 	switch (state) {
 	case IPC_CLIENT_CMD_STATE_REPLY:
 		/* shouldn't get here. the command reply isn't finished yet. */
+		i_error("login process sent unexpected reply to kick: %s", data);
 		return;
 	case IPC_CLIENT_CMD_STATE_OK:
 		break;
@@ -1141,10 +1142,14 @@ void director_move_user(struct director *dir, struct director_host *src,
 }
 
 static void
-director_kick_user_callback(enum ipc_client_cmd_state state ATTR_UNUSED,
-			    const char *data ATTR_UNUSED,
-			    void *context ATTR_UNUSED)
+director_kick_user_callback(enum ipc_client_cmd_state state,
+			    const char *data, void *context ATTR_UNUSED)
 {
+	if (state == IPC_CLIENT_CMD_STATE_REPLY) {
+		/* shouldn't get here. the command reply isn't finished yet. */
+		i_error("login process sent unexpected reply to kick: %s", data);
+	}
+
 }
 
 void director_kick_user(struct director *dir, struct director_host *src,