From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Wed, 20 Nov 2024 00:53:25 +0000 (+0100)
Subject: lib-http: http-client-request - Make http_client_request_unref(NULL) a no-op
X-Git-Tag: 2.4.1~76
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ccb22575d8c5f6e7e80ca6905385e9db099ede01;p=thirdparty%2Fdovecot%2Fcore.git

lib-http: http-client-request - Make http_client_request_unref(NULL) a no-op
---

diff --git a/src/lib-http/http-client-request.c b/src/lib-http/http-client-request.c
index 3e310bdb4c..d640978c50 100644
--- a/src/lib-http/http-client-request.c
+++ b/src/lib-http/http-client-request.c
@@ -312,15 +312,17 @@ void http_client_request_ref(struct http_client_request *req)
 bool http_client_request_unref(struct http_client_request **_req)
 {
 	struct http_client_request *req = *_req;
-	struct http_client *client = req->client;
-
-	i_assert(req->refcount > 0);
 
+	if (req == NULL)
+		return FALSE;
 	*_req = NULL;
 
+	i_assert(req->refcount > 0);
 	if (--req->refcount > 0)
 		return TRUE;
 
+	struct http_client *client = req->client;
+
 	if (client == NULL) {
 		e_debug(req->event, "Free (client already destroyed)");
 	} else {