From: Jim Meyering <meyering@fb.com>
Date: Mon, 19 Mar 2018 00:59:25 +0000 (-0700)
Subject: maint: avoid warnings from upcoming GCC8
X-Git-Tag: release_1_31~32
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ccef8581b8673cadd1c084595de4efde956c3c2b;p=thirdparty%2Ftar.git

maint: avoid warnings from upcoming GCC8

* src/transform.c (_single_transform_name_to_obstack): Mark with
FALLTHROUGH statement rather than /* FALL THROUGH */ comment.
Only the former works with gcc-8.
* src/extract.c (maybe_recoverable): Call abort to tell gcc-8 that
this code is unreachable.
---

diff --git a/src/extract.c b/src/extract.c
index 395db557..74987bba 100644
--- a/src/extract.c
+++ b/src/extract.c
@@ -788,6 +788,7 @@ maybe_recoverable (char *file_name, bool regular, bool *interdir_made)
 	case UNLINK_FIRST_OLD_FILES:
 	  break;
 	}
+      abort (); /* notreached */
 
     case ENOENT:
       /* Attempt creating missing intermediate directories.  */
diff --git a/src/transform.c b/src/transform.c
index e450dd22..3fae3c0d 100644
--- a/src/transform.c
+++ b/src/transform.c
@@ -550,7 +550,7 @@ _single_transform_name_to_obstack (struct transform *tf, char *input)
 			default:
 			  break;
 			}
-		      /*FALL THROUGH*/
+		      FALLTHROUGH;
 
 		    case ctl_upcase:
 		    case ctl_locase: