From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 16 Oct 2021 09:39:18 +0000 (+0200)
Subject: refs API: ignore errno in worktree.c's add_head_info()
X-Git-Tag: v2.35.0-rc0~135^2~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ccf3cc1b189f732cb1e99b08bda37e92a896047f;p=thirdparty%2Fgit.git

refs API: ignore errno in worktree.c's add_head_info()

The static add_head_info() function is only used indirectly by callers
of get_worktrees(), none of whom care about errno, and even if they
did having the faked-up one from refs_resolve_ref_unsafe() would only
confuse them if they used die_errno() et al. So let's explicitly
ignore it here.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/worktree.c b/worktree.c
index cfffcdb62b..fa988ee978 100644
--- a/worktree.c
+++ b/worktree.c
@@ -28,11 +28,13 @@ static void add_head_info(struct worktree *wt)
 {
 	int flags;
 	const char *target;
+	int ignore_errno;
 
-	target = refs_resolve_ref_unsafe(get_worktree_ref_store(wt),
+	target = refs_werrres_ref_unsafe(get_worktree_ref_store(wt),
 					 "HEAD",
 					 0,
-					 &wt->head_oid, &flags);
+					 &wt->head_oid, &flags,
+					 &ignore_errno);
 	if (!target)
 		return;