From: Dragan Dosen <ddosen@haproxy.com>
Date: Mon, 18 Sep 2017 06:20:33 +0000 (+0200)
Subject: BUG/MINOR: contrib/mod_defender: close the va_list argp before return
X-Git-Tag: v1.8-dev3~83
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ccf6100e11769b1650ba56fa727cb51993d0f3d2;p=thirdparty%2Fhaproxy.git

BUG/MINOR: contrib/mod_defender: close the va_list argp before return

Fix the case when the va_list argp could be left open if the function
vsnprintf() returned a negative value.
---

diff --git a/contrib/mod_defender/defender.c b/contrib/mod_defender/defender.c
index c86d25e0a8..17341760c6 100644
--- a/contrib/mod_defender/defender.c
+++ b/contrib/mod_defender/defender.c
@@ -149,9 +149,10 @@ static char *defender_printf(apr_pool_t *pool, const char *fmt, ...)
 
 	va_start(argp, fmt);
 	len = vsnprintf(NULL, 0, fmt, argp);
+	va_end(argp);
+
 	if (len < 0)
 		return NULL;
-	va_end(argp);
 
 	if (!(dst = apr_pcalloc(pool, len + 1)))
 		return NULL;