From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 4 Jul 2025 07:39:10 +0000 (+0200)
Subject: On second thought, revert 2a8a5c7629984e51b717494a23c0c6651de0b030.
X-Git-Tag: rec-5.3.0-alpha2~7^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ccf890cba3c9994d8cb55955e02aff8d8a28efe0;p=thirdparty%2Fpdns.git

On second thought, revert 2a8a5c7629984e51b717494a23c0c6651de0b030.

We are only removing ENT when we know for sure that there are other
records for that name, so there is no risk of orphaning NSEC3 chains.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 6982323b4b..300b6bf2c1 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -2828,11 +2828,6 @@ bool LMDBBackend::updateEmptyNonTerminals(domainid_t domain_id, set<DNSName>& in
       // cout <<" -"<<n<<endl;
       n.makeUsRelative(di.zone);
       txn->txn->del(txn->db->dbi, co(domain_id, n, QType::ENT));
-      // Remove possible orphaned NSEC3 record pair tied to that ENT.
-      auto cursor = txn->txn->getCursor(txn->db->dbi);
-      if (hasOrphanedNSEC3Record(cursor, domain_id, n)) {
-        deleteNSEC3RecordPair(txn, domain_id, n);
-      }
     }
   }
   if (needCommit)