From: Willy Tarreau <w@1wt.eu>
Date: Sat, 3 Apr 2021 13:26:56 +0000 (+0200)
Subject: CLEANUP: dev/flags: remove useless test in the stdin number parser
X-Git-Tag: v2.4-dev16~37
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cd430b9b7be2663e79692a39d2362e6a9d81e2a6;p=thirdparty%2Fhaproxy.git

CLEANUP: dev/flags: remove useless test in the stdin number parser

The test on "if (err)" after parsing a number was meant to be
"if (*err)" but in practise it will always be true since we at least
have a '\n' there, so no need for testing before writing zero.
This fixes issue #1211.
---

diff --git a/dev/flags/flags.c b/dev/flags/flags.c
index 669bd090c9..ccd22050d8 100644
--- a/dev/flags/flags.c
+++ b/dev/flags/flags.c
@@ -441,8 +441,7 @@ int main(int argc, char **argv)
 			while (*err == '-' || *err == '+' ||
 			       (isalnum((unsigned char)*err) && toupper((unsigned char)*err) != 'U' && toupper((unsigned char)*err) != 'L'))
 				err++;
-			if (err)
-				*err = 0;
+			*err = 0;
 		} else {
 			value = argv[0];
 			argv++; argc--;