From: Tom Tromey <tom@tromey.com>
Date: Sun, 15 Dec 2024 16:09:10 +0000 (-0700)
Subject: Fix latent bug in gdbpy_lookup_static_symbols
X-Git-Tag: gdb-16-branchpoint~34
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cd676397e5a7920eb0fc916bfde787dde8dea149;p=thirdparty%2Fbinutils-gdb.git

Fix latent bug in gdbpy_lookup_static_symbols

gdbpy_lookup_static_symbols is missing an error check for the case
where symbol_to_symbol_object returns NULL.

Approved-By: Tom de Vries <tdevries@suse.de>
---

diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c
index c1f8d6c95e0..8648a5073d0 100644
--- a/gdb/python/py-symbol.c
+++ b/gdb/python/py-symbol.c
@@ -632,10 +632,11 @@ gdbpy_lookup_static_symbols (PyObject *self, PyObject *args, PyObject *kw)
 
 		  if (symbol != nullptr)
 		    {
-		      PyObject *sym_obj
-			= symbol_to_symbol_object (symbol);
+		      PyObject *sym_obj = symbol_to_symbol_object (symbol);
+		      if (sym_obj == nullptr)
+			return nullptr;
 		      if (PyList_Append (return_list.get (), sym_obj) == -1)
-			return NULL;
+			return nullptr;
 		    }
 		}
 	    }