From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sun, 29 May 2022 15:02:21 +0000 (+0000)
Subject: users: Return NotImplemented when we cannot compare
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cd849b465aac071002d2b794b0dbe5dd1b03df3c;p=pbs.git

users: Return NotImplemented when we cannot compare

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/buildservice/users.py b/src/buildservice/users.py
index 647515ad..4a802d73 100644
--- a/src/buildservice/users.py
+++ b/src/buildservice/users.py
@@ -193,6 +193,8 @@ class User(base.DataObject):
 		if isinstance(other, self.__class__):
 			return self.id == other.id
 
+		return NotImplemented
+
 	def __lt__(self, other):
 		if isinstance(other, self.__class__):
 			return self.name < other.name
@@ -200,6 +202,8 @@ class User(base.DataObject):
 		elif isinstance(other, str):
 			return self.name < other
 
+		return NotImplemented
+
 	def delete(self):
 		self._set_attribute("deleted", True)
 
@@ -408,6 +412,8 @@ class UserEmail(base.DataObject):
 		elif isinstance(other, str):
 			return self.email == other
 
+		return NotImplemented
+
 	@lazy_property
 	def user(self):
 		return self.backend.users.get_by_id(self.data.user_id)