From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 5 Sep 2024 10:08:59 +0000 (+0200)
Subject: remote: fix leaking tracking refs
X-Git-Tag: v2.47.0-rc0~28^2~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cdbb7208c80661754b3f1a73aef086c08f88dcff;p=thirdparty%2Fgit.git

remote: fix leaking tracking refs

When computing the remote tracking ref we cause two memory leaks:

  - We leak when `remote_tracking()` fails.

  - We leak when the call to `remote_tracking()` succeeds and sets
    `ref->tracking_ref()`.

Fix both of these leaks.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/remote.c b/remote.c
index 7d5b8f750d..8d666c1641 100644
--- a/remote.c
+++ b/remote.c
@@ -1097,6 +1097,7 @@ void free_one_ref(struct ref *ref)
 		return;
 	free_one_ref(ref->peer_ref);
 	free(ref->remote_status);
+	free(ref->tracking_ref);
 	free(ref->symref);
 	free(ref);
 }
@@ -2577,8 +2578,10 @@ static int remote_tracking(struct remote *remote, const char *refname,
 	dst = apply_refspecs(&remote->fetch, refname);
 	if (!dst)
 		return -1; /* no tracking ref for refname at remote */
-	if (refs_read_ref(get_main_ref_store(the_repository), dst, oid))
+	if (refs_read_ref(get_main_ref_store(the_repository), dst, oid)) {
+		free(dst);
 		return -1; /* we know what the tracking ref is but we cannot read it */
+	}
 
 	*dst_refname = dst;
 	return 0;