From: Ross Burton <ross.burton@arm.com>
Date: Tue, 21 Nov 2023 14:06:17 +0000 (+0000)
Subject: lib/oe/patch: ensure os.chdir restoring always happens
X-Git-Tag: uninative-4.4~982
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cdc40292818683b6df1c814498c7589450a163fa;p=thirdparty%2Fopenembedded%2Fopenembedded-core.git

lib/oe/patch: ensure os.chdir restoring always happens

If we chdir(), do the chdir back to the original directory in a finally
block so they always run.

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/meta/lib/oe/patch.py b/meta/lib/oe/patch.py
index ff9afc9df9f..9b480b2b285 100644
--- a/meta/lib/oe/patch.py
+++ b/meta/lib/oe/patch.py
@@ -772,8 +772,9 @@ class NOOPResolver(Resolver):
             self.patchset.Push()
         except Exception:
             import sys
-            os.chdir(olddir)
             raise
+        finally:
+            os.chdir(olddir)
 
 # Patch resolver which relies on the user doing all the work involved in the
 # resolution, with the exception of refreshing the remote copy of the patch
@@ -833,9 +834,9 @@ class UserResolver(Resolver):
                             # User did not fix the problem.  Abort.
                             raise PatchError("Patch application failed, and user did not fix and refresh the patch.")
         except Exception:
-            os.chdir(olddir)
             raise
-        os.chdir(olddir)
+        finally:
+            os.chdir(olddir)
 
 
 def patch_path(url, fetch, workdir, expand=True):