From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Tue, 20 Jan 2015 00:54:55 +0000 (+0100)
Subject: tests: use returns_ function for new split test
X-Git-Tag: v8.24~144
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cdd21d31a3fdd4ffd7a90fa3b43fb7f1c08d8f6d;p=thirdparty%2Fcoreutils.git

tests: use returns_ function for new split test

* tests/split/record-sep.sh: Use the recently added returns_ function
to simplify the shell syntax in this test.  Also remove the redirection
of stdout/stderr to /dev/null as this eases analyzing errors.
---

diff --git a/tests/split/record-sep.sh b/tests/split/record-sep.sh
index f41215a457..69eb27fae0 100755
--- a/tests/split/record-sep.sh
+++ b/tests/split/record-sep.sh
@@ -55,23 +55,23 @@ done
 #
 
 # Should fail: '-t' requires an argument
-{ split -t </dev/null >/dev/null 2>/dev/null || test $? -ne 1; } &&
+returns_ 1 split -t </dev/null ||
   { warn_ "-t without argument did not trigger an error" ; fail=1 ; }
 
 # should fail: multi-character separator
-{ split -txx </dev/null >/dev/null 2>&1 || test $? -ne 1; } &&
+returns_ 1 split -txx </dev/null ||
   { warn_ "-txx did not trigger an error" ; fail=1 ; }
 
 # should fail: different separators used
-{ split -ta -tb </dev/null >/dev/null 2>&1 || test $? -ne 1; } &&
+returns_ 1 split -ta -tb </dev/null ||
   { warn_ "-ta -tb did not trigger an error" ; fail=1 ; }
 
 # should fail: different separators used, including default
-{ split -t"$NL" -tb </dev/null >/dev/null 2>&1 || test $? -ne 1; } &&
+returns_ 1 split -t"$NL" -tb </dev/null ||
   { warn_ "-t\$NL -tb did not trigger an error" ; fail=1 ; }
 
 # should not fail: same separator used multiple times
-split -t: -t: </dev/null >/dev/null 2>&1 ||
+split -t: -t: </dev/null ||
   { warn_ "-t: -t: triggered an error" ; fail=1 ; }