From: Lorenzo Bianconi Date: Thu, 30 Jul 2020 09:21:31 +0000 (+0200) Subject: mt76: mt7615: hold mt76 lock queueing wd in mt7615_queue_key_update X-Git-Tag: v5.10-rc1~107^2~150^2~2^2~82 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cddaaa56375615c256eb6960d3092ddb8a7a9154;p=thirdparty%2Fkernel%2Flinux.git mt76: mt7615: hold mt76 lock queueing wd in mt7615_queue_key_update wq queue is always updated holding mt76 spinlock. Grab mt76 lock in mt7615_queue_key_update() before putting a new element at the end of the queue. Fixes: eb99cc95c3b65 ("mt76: mt7615: introduce mt7663u support") Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau --- diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c b/drivers/net/wireless/mediatek/mt76/mt7615/main.c index 2d0b1f49fdbcf..bafe2bdeb5eb4 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/main.c @@ -361,7 +361,10 @@ mt7615_queue_key_update(struct mt7615_dev *dev, enum set_key_cmd cmd, wd->key.keylen = key->keylen; wd->key.cmd = cmd; + spin_lock_bh(&dev->mt76.lock); list_add_tail(&wd->node, &dev->wd_head); + spin_unlock_bh(&dev->mt76.lock); + queue_work(dev->mt76.wq, &dev->wtbl_work); return 0;