From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 10 Sep 2024 09:30:24 +0000 (+0800)
Subject: crypto: n2 - Set err to EINVAL if snprintf fails for hmac
X-Git-Tag: v6.12-rc1~231^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ce212d2afca47acd366a2e74c76fe82c31f785ab;p=thirdparty%2Flinux.git

crypto: n2 - Set err to EINVAL if snprintf fails for hmac

Return EINVAL if the snprintf check fails when constructing the
algorithm names.

Fixes: 8c20982caca4 ("crypto: n2 - Silence gcc format-truncation false positive warnings")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202409090726.TP0WfY7p-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index 251e088a53dff..b11545cc5cb79 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -1353,6 +1353,7 @@ static int __n2_register_one_hmac(struct n2_ahash_alg *n2ahash)
 	ahash->setkey = n2_hmac_async_setkey;
 
 	base = &ahash->halg.base;
+	err = -EINVAL;
 	if (snprintf(base->cra_name, CRYPTO_MAX_ALG_NAME, "hmac(%s)",
 		     p->child_alg) >= CRYPTO_MAX_ALG_NAME)
 		goto out_free_p;