From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Tue, 20 Jul 2010 05:59:41 +0000 (-0700)
Subject: Bug 575475: ANSI coloring of error messages was hiding template compilation
X-Git-Tag: bugzilla-4.1.1~366
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ce4cf0862c192c334e83de08f30a437da3aea888;p=thirdparty%2Fbugzilla.git

Bug 575475: ANSI coloring of error messages was hiding template compilation
errors
r=LpSolit, a=LpSolit
---

diff --git a/Bugzilla/Install/Util.pm b/Bugzilla/Install/Util.pm
index 1e5a7b5e13..41f608abfe 100644
--- a/Bugzilla/Install/Util.pm
+++ b/Bugzilla/Install/Util.pm
@@ -622,7 +622,9 @@ sub _console_die {
     # that it should put "at Bugzilla/Install.pm line 1234" after the
     # message.
     $message =~ s/\n+$//;
-    die colored($message, COLOR_ERROR) . "\n";
+    # We put quotes around the message to stringify any object exceptions,
+    # like Template::Exception.
+    die colored("$message", COLOR_ERROR) . "\n";
 }
 
 sub prevent_windows_dialog_boxes {