From: Sander Vanheule Date: Wed, 9 Jun 2021 13:10:03 +0000 (+0200) Subject: regmap: mdio: Fix regmap_bus pointer constness X-Git-Tag: v5.14-rc1~189^2^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ce62df2290bb86b39f826a835d6060bc3b43dae7;p=thirdparty%2Fkernel%2Flinux.git regmap: mdio: Fix regmap_bus pointer constness A const qualifier was omitted in the declaration of the regmap_bus pointer, resulting in the following errors: drivers/base/regmap/regmap-mdio.c: In function ‘__regmap_init_mdio’: drivers/base/regmap/regmap-mdio.c:87:7: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 87 | bus = ®map_mdio_c22_bus; | ^ drivers/base/regmap/regmap-mdio.c:89:7: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 89 | bus = ®map_mdio_c45_bus; | ^ Fix this by ensuring the pointer has the same qualifiers as the assigned values. Fixes: f083be9db060 ("regmap: mdio: Add clause-45 support") Signed-off-by: Sander Vanheule Link: https://lore.kernel.org/r/f304ca638ffdc66d4803a6df1f75436894bd1d5f.1623244066.git.sander@svanheule.net Signed-off-by: Mark Brown --- diff --git a/drivers/base/regmap/regmap-mdio.c b/drivers/base/regmap/regmap-mdio.c index cfb23afb19ebf..b772b42809e28 100644 --- a/drivers/base/regmap/regmap-mdio.c +++ b/drivers/base/regmap/regmap-mdio.c @@ -69,7 +69,7 @@ struct regmap *__regmap_init_mdio(struct mdio_device *mdio_dev, const struct regmap_config *config, struct lock_class_key *lock_key, const char *lock_name) { - struct regmap_bus *bus; + const struct regmap_bus *bus; if (config->reg_bits == 5 && config->val_bits == 16) bus = ®map_mdio_c22_bus;