From: Tom Tromey <tom@tromey.com>
Date: Sun, 17 Dec 2023 20:22:10 +0000 (-0700)
Subject: Remove useless call to wnoutrefresh
X-Git-Tag: binutils-2_43~448
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ce6b89bfdfd530551a6c00761aaf1e4bb204c2be;p=thirdparty%2Fbinutils-gdb.git

Remove useless call to wnoutrefresh

This call to wnoutrefresh is not useful.  It's based on the
misunderstanding that wnoutrefresh somehow prevents display, whereas
actually what it does is copy from one curses buffer to another.

I'm working on a larger patch to clean up this area, but this
particular call can be removed immediately without consequence.

Approved-By: Andrew Burgess <aburgess@redhat.com>
---

diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c
index 11530472687..d113d77c4ab 100644
--- a/gdb/tui/tui-wingeneral.c
+++ b/gdb/tui/tui-wingeneral.c
@@ -165,8 +165,6 @@ tui_win_info::make_window ()
   handle.reset (newwin (height, width, y, x));
   if (handle != NULL)
     {
-      if (suppress_output)
-	wnoutrefresh (handle.get ());
       scrollok (handle.get (), TRUE);
       if (can_box ())
 	box_win (this, false);