From: Subramanian Ananthanarayanan Date: Wed, 16 Apr 2025 05:19:51 +0000 (+0530) Subject: bus: mhi: host: pci_generic: Remove redundant assign resource usage X-Git-Tag: v6.16-rc1~30^2~38^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ce7cc522e9ffbad8663cb0b69eba928107b5909c;p=thirdparty%2Flinux.git bus: mhi: host: pci_generic: Remove redundant assign resource usage Avoid redundant usage of pci_assign_resource for BAR allocation. This is already taken care by PCI framework. Invocation of this API leads to unnecessary relocation of BAR space to a new memory address. Signed-off-by: Subramanian Ananthanarayanan Signed-off-by: Manivannan Sadhasivam Reviewed-by: Krishna Chaitanya Chundru Link: https://patch.msgid.link/20250416-remove_assin_resource-v1-1-e92dd361fa0a@quicinc.com --- diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c index 03aa88795209..7501abc835c7 100644 --- a/drivers/bus/mhi/host/pci_generic.c +++ b/drivers/bus/mhi/host/pci_generic.c @@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl, struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev); int err; - err = pci_assign_resource(pdev, bar_num); - if (err) - return err; - err = pcim_enable_device(pdev); if (err) { dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);