From: Alberto Leiva Popper <ydahhrk@gmail.com>
Date: Wed, 19 Jan 2022 02:27:30 +0000 (-0600)
Subject: HTTP: Shut up file delete error message
X-Git-Tag: 1.5.4~22
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ce8ed0b9b112d7eebd0330745fb8aac7e73f1e5f;p=thirdparty%2FFORT-validator.git

HTTP: Shut up file delete error message

For #67.

When the file didn't need to be downloaded, because the IMS header did
its job, nothing needs to be deleted. So Fort shouldn't be complaining.

Like the previous commit, this is not a great solution, because IMS is
not the only trigger of file deletes, and the error message might be
helpful in other cases. Then again, I don't really agree with this eager
repository cleaning technique; it complicates debugging.

The proper solution is a WIP in the rrdp-refactor branch.
---

diff --git a/src/common.c b/src/common.c
index 2384f3ea..c19389e0 100644
--- a/src/common.c
+++ b/src/common.c
@@ -306,9 +306,11 @@ remove_file(char const *path)
 	errno = 0;
 	if (remove(path) != 0) {
 		error = errno;
+		/*
 		pr_val_err("Couldn't delete '%s': %s", path,
 		    strerror(error));
-		return errno;
+		 */
+		return error;
 	}
 
 	return 0;