From: Aurelien DARRAGON <adarragon@haproxy.com>
Date: Thu, 11 May 2023 13:28:20 +0000 (+0200)
Subject: MINOR: ncbuf: missing malloc checks in standalone code
X-Git-Tag: v2.8-dev12~49
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ceb13b5ed33271dfd7e8a324263bef9eddc733f6;p=thirdparty%2Fhaproxy.git

MINOR: ncbuf: missing malloc checks in standalone code

Some malloc resulsts were not checked in standalone ncbuf code.

As this is debug/test code, we don't need to explicitly handle memory
errors, we just add some BUG_ON() to ensure that memory is properly
allocated and prevent unexpected results.

This partially fixes issue GH #2130.

No backport needed.
---

diff --git a/src/ncbuf.c b/src/ncbuf.c
index a96cf598ed..e1452f1d27 100644
--- a/src/ncbuf.c
+++ b/src/ncbuf.c
@@ -810,9 +810,11 @@ static int ncbuf_test(ncb_sz_t head, int reset, int print_delay)
 	enum ncb_ret ret;
 
 	data0 = malloc(bufsize);
+	BUG_ON(!data0);
 	memset(data0, 0xff, bufsize);
 
 	bufarea = malloc(bufsize);
+	BUG_ON(!bufarea);
 
 	fprintf(stderr, "running unit tests\n");