From: Alexander Vasin <hi@alvass.in>
Date: Fri, 3 May 2019 15:25:36 +0000 (+0300)
Subject: Fixed typo (GH-11522)
X-Git-Tag: v3.8.0a4~17
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ceb842e155f5fa0109fa88d52da3d1f5e73490ad;p=thirdparty%2FPython%2Fcpython.git

Fixed typo (GH-11522)



Given example does not run, loop variable is missing.

Secondly, this is bad example how to handle shutdown signal, because it would cause `RuntimeError: Event loop stopped before Future completed.`

Perhaps it would be better to cancel all tasks instead of closing loop directly?

Did not create issue, because question is quite simple.
---

diff --git a/Doc/library/asyncio-eventloop.rst b/Doc/library/asyncio-eventloop.rst
index bf7c93a86fd0..e2b312453921 100644
--- a/Doc/library/asyncio-eventloop.rst
+++ b/Doc/library/asyncio-eventloop.rst
@@ -1601,7 +1601,7 @@ using the :meth:`loop.add_signal_handler` method::
     import os
     import signal
 
-    def ask_exit(signame):
+    def ask_exit(signame, loop):
         print("got signal %s: exit" % signame)
         loop.stop()
 
@@ -1611,7 +1611,7 @@ using the :meth:`loop.add_signal_handler` method::
         for signame in {'SIGINT', 'SIGTERM'}:
             loop.add_signal_handler(
                 getattr(signal, signame),
-                functools.partial(ask_exit, signame))
+                functools.partial(ask_exit, signame, loop))
 
         await asyncio.sleep(3600)