From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:53 +0000 (+0000) Subject: media: c8sectpfe: Refactor load_c8sectpfe_fw X-Git-Tag: v6.10-rc1~135^2~222 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cf8da3293b0b86c08e960c020cd667bd878c42d6;p=thirdparty%2Fkernel%2Flinux.git media: c8sectpfe: Refactor load_c8sectpfe_fw release_firmware() in the same function that it was requested. It is more clear and makes smatch happy. drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1146 load_c8sectpfe_fw() warn: 'fw' from request_firmware() not released on lines: 1125,1132. Signed-off-by: Ricardo Ribalda Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c index 0df2a1b4974b2..2f58a0d0df855 100644 --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c @@ -1096,7 +1096,6 @@ static int load_slim_core_fw(const struct firmware *fw, struct c8sectpfei *fei) } } - release_firmware(fw); return err; } @@ -1120,6 +1119,7 @@ static int load_c8sectpfe_fw(struct c8sectpfei *fei) } err = load_slim_core_fw(fw, fei); + release_firmware(fw); if (err) { dev_err(fei->dev, "load_slim_core_fw failed err=(%d)\n", err); return err;