From: Pan Bian Date: Wed, 28 Nov 2018 06:53:19 +0000 (+0800) Subject: rapidio/rionet: do not free skb before reading its length X-Git-Tag: v4.20-rc5~35^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=cfc435198f53a6fa1f656d98466b24967ff457d0;p=thirdparty%2Fkernel%2Flinux.git rapidio/rionet: do not free skb before reading its length skb is freed via dev_kfree_skb_any, however, skb->len is read then. This may result in a use-after-free bug. Fixes: e6161d64263 ("rapidio/rionet: rework driver initialization and removal") Signed-off-by: Pan Bian Signed-off-by: David S. Miller --- diff --git a/drivers/net/rionet.c b/drivers/net/rionet.c index e9f101c9bae2c..bfbb39f935545 100644 --- a/drivers/net/rionet.c +++ b/drivers/net/rionet.c @@ -216,9 +216,9 @@ static int rionet_start_xmit(struct sk_buff *skb, struct net_device *ndev) * it just report sending a packet to the target * (without actual packet transfer). */ - dev_kfree_skb_any(skb); ndev->stats.tx_packets++; ndev->stats.tx_bytes += skb->len; + dev_kfree_skb_any(skb); } }