From: Andrei Pavel <andrei@isc.org>
Date: Tue, 18 Mar 2025 08:38:40 +0000 (+0200)
Subject: [#3731] Fix locations of lockfile dir, kea-admin, kea-lfc in case of installation
X-Git-Tag: Kea-2.7.7~46
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d02c6530d93022bdf48993def471da34583a1c54;p=thirdparty%2Fkea.git

[#3731] Fix locations of lockfile dir, kea-admin, kea-lfc in case of installation
---

diff --git a/fuzz/meson.build b/fuzz/meson.build
index 1af2b17d99..e0d59238d7 100644
--- a/fuzz/meson.build
+++ b/fuzz/meson.build
@@ -6,8 +6,8 @@ subdir('tests')
 
 fuzz_sources = ['fuzz.cc', 'fuzz.h']
 cpp_flags = [
-    f'-DKEA_LFC_SOURCES="@KEA_LFC@"',
     f'-DKEA_LFC_INSTALLATION="@PREFIX@/sbin/kea-lfc"',
+    f'-DKEA_LFC_SOURCES="@TOP_BUILD_DIR@/src/bin/lfc/kea-lfc"',
 ]
 if FUZZING_WITH_CLUSTERFUZZLITE
     cpp_flags = ['-fsanitize=fuzzer', '-gdwarf-4']
diff --git a/meson.build b/meson.build
index c4ebd71933..26a4df1778 100644
--- a/meson.build
+++ b/meson.build
@@ -45,13 +45,11 @@ PREFIX = get_option('prefix')
 SBINDIR = get_option('sbindir')
 SYSCONFDIR = get_option('sysconfdir')
 
-DHCP_DATA_DIR = f'@LOCALSTATEDIR@/run/kea'
-DEFAULT_HOOKS_PATH = f'@PREFIX@/lib/kea/hooks'
-KEA_ADMIN = f'@TOP_BUILD_DIR@/src/bin/admin/kea-admin'
-KEA_LFC = f'@TOP_BUILD_DIR@/src/bin/lfc/kea-lfc'
-TEST_CA_DIR = f'@TOP_SOURCE_DIR@/src/lib/asiolink/testutils/ca'
-DATABASE_SCRIPTS_DIR = f'@TOP_BUILD_DIR@/src/share/database/scripts'
-LEGAL_LOG_DIR = f'@PREFIX@/@LOCALSTATEDIR@/lib/kea'
+DHCP_DATA_DIR = LOCALSTATEDIR / 'run/kea'
+DEFAULT_HOOKS_PATH = PREFIX / 'lib/kea/hooks'
+TEST_CA_DIR = TOP_SOURCE_DIR / 'src/lib/asiolink/testutils/ca'
+DATABASE_SCRIPTS_DIR = TOP_BUILD_DIR / 'src/share/database/scripts'
+LEGAL_LOG_DIR = PREFIX / LOCALSTATEDIR / 'lib/kea'
 
 #### Build Options
 
diff --git a/src/bin/dhcp4/tests/meson.build b/src/bin/dhcp4/tests/meson.build
index 7cd0fe58fa..6a0d33c149 100644
--- a/src/bin/dhcp4/tests/meson.build
+++ b/src/bin/dhcp4/tests/meson.build
@@ -138,7 +138,7 @@ kea_dhcp4_tests = executable(
         f'-DCFG_EXAMPLES="@TOP_SOURCE_DIR@/doc/examples/kea4"',
         f'-DDHCP_DATA_DIR="@current_build_dir@"',
         f'-DSYNTAX_FILE="@current_source_dir@/../dhcp4_parser.yy"',
-        f'-DKEA_LFC_EXECUTABLE="@KEA_LFC@"',
+        f'-DKEA_LFC_EXECUTABLE="@TOP_BUILD_DIR@/src/bin/lfc/kea-lfc"',
         f'-DTEST_CA_DIR="@TEST_CA_DIR@"',
     ],
     dependencies: dhcp4_tests_deps,
diff --git a/src/bin/dhcp6/tests/meson.build b/src/bin/dhcp6/tests/meson.build
index 1051503321..ccc69ce498 100644
--- a/src/bin/dhcp6/tests/meson.build
+++ b/src/bin/dhcp6/tests/meson.build
@@ -140,7 +140,7 @@ kea_dhcp6_tests = executable(
         f'-DCFG_EXAMPLES="@TOP_SOURCE_DIR@/doc/examples/kea6"',
         f'-DDHCP_DATA_DIR="@current_build_dir@"',
         f'-DSYNTAX_FILE="@current_source_dir@/../dhcp6_parser.yy"',
-        f'-DKEA_LFC_EXECUTABLE="@KEA_LFC@"',
+        f'-DKEA_LFC_EXECUTABLE="@TOP_BUILD_DIR@/src/bin/lfc/kea-lfc"',
         f'-DTEST_CA_DIR="@TEST_CA_DIR@"',
     ],
     dependencies: dhcp6_tests_deps,
diff --git a/src/lib/dhcpsrv/meson.build b/src/lib/dhcpsrv/meson.build
index 7905afcfa5..38b4f2a3f3 100644
--- a/src/lib/dhcpsrv/meson.build
+++ b/src/lib/dhcpsrv/meson.build
@@ -93,7 +93,7 @@ kea_dhcpsrv_lib = shared_library(
     sources,
     cpp_args: [
         f'-DDHCP_DATA_DIR="@DHCP_DATA_DIR@"',
-        f'-DKEA_LFC_EXECUTABLE="@KEA_LFC@"',
+        f'-DKEA_LFC_EXECUTABLE="@PREFIX@/@SBINDIR@/kea-lfc"',
     ],
     dependencies: [CRYPTO_DEP],
     include_directories: [include_directories('.')] + INCLUDES,
diff --git a/src/lib/log/interprocess/meson.build b/src/lib/log/interprocess/meson.build
index 48070da3bc..f4232d68f2 100644
--- a/src/lib/log/interprocess/meson.build
+++ b/src/lib/log/interprocess/meson.build
@@ -2,7 +2,7 @@ kea_log_interprocess_lib = shared_library(
     'kea-log-interprocess',
     'interprocess_sync_file.cc',
     'interprocess_sync_null.cc',
-    cpp_args: [f'-DLOCKFILE_DIR="@LOCALSTATEDIR@/run/kea"'],
+    cpp_args: [f'-DLOCKFILE_DIR="@PREFIX@/@LOCALSTATEDIR@/run/kea"'],
     include_directories: [include_directories('.')] + INCLUDES,
     install: true,
     install_dir: LIBDIR,
diff --git a/src/lib/mysql/meson.build b/src/lib/mysql/meson.build
index 9d416ce8c9..c750222ac9 100644
--- a/src/lib/mysql/meson.build
+++ b/src/lib/mysql/meson.build
@@ -6,7 +6,7 @@ kea_mysql_lib = shared_library(
     'kea-mysql',
     'mysql_binding.cc',
     'mysql_connection.cc',
-    cpp_args: [f'-DKEA_ADMIN="@KEA_ADMIN@"'],
+    cpp_args: [f'-DKEA_ADMIN="@PREFIX@/@SBINDIR@/kea-admin"'],
     dependencies: [MYSQL_DEP],
     include_directories: [include_directories('.')] + INCLUDES,
     install: true,
diff --git a/src/lib/mysql/tests/meson.build b/src/lib/mysql/tests/meson.build
index 83b6784cb6..af565bbec6 100644
--- a/src/lib/mysql/tests/meson.build
+++ b/src/lib/mysql/tests/meson.build
@@ -12,7 +12,7 @@ kea_mysql_tests = executable(
     'mysql_binding_unittest.cc',
     'mysql_connection_unittest.cc',
     'run_unittests.cc',
-    cpp_args: [f'-DTEST_CA_DIR="@TEST_CA_DIR@"', f'-DKEA_ADMIN="@KEA_ADMIN@"'],
+    cpp_args: [f'-DTEST_CA_DIR="@TEST_CA_DIR@"', f'-DKEA_ADMIN="@TOP_BUILD_DIR@/src/bin/admin/kea-admin"'],
     dependencies: [GTEST_DEP, MYSQL_DEP],
     include_directories: [include_directories('.')] + INCLUDES,
     link_with: [kea_util_unittests_lib, libs_testutils] + LIBS_BUILT_SO_FAR,
diff --git a/src/lib/pgsql/meson.build b/src/lib/pgsql/meson.build
index 957c03ed11..41de5ce4d0 100644
--- a/src/lib/pgsql/meson.build
+++ b/src/lib/pgsql/meson.build
@@ -6,7 +6,7 @@ kea_pgsql_lib = shared_library(
     'kea-pgsql',
     'pgsql_connection.cc',
     'pgsql_exchange.cc',
-    cpp_args: [f'-DKEA_ADMIN="@KEA_ADMIN@"'],
+    cpp_args: [f'-DKEA_ADMIN="@PREFIX@/@SBINDIR@/kea-admin"'],
     dependencies: [POSTGRESQL_DEP],
     include_directories: [include_directories('.')] + INCLUDES,
     install: true,
diff --git a/src/lib/pgsql/tests/meson.build b/src/lib/pgsql/tests/meson.build
index d4350b5f4a..c4845e76d6 100644
--- a/src/lib/pgsql/tests/meson.build
+++ b/src/lib/pgsql/tests/meson.build
@@ -13,7 +13,7 @@ kea_pgsql_tests = executable(
     'pgsql_connection_unittest.cc',
     'pgsql_exchange_unittest.cc',
     'run_unittests.cc',
-    cpp_args: [f'-DTEST_CA_DIR="@TEST_CA_DIR@"', f'-DKEA_ADMIN="@KEA_ADMIN@"'],
+    cpp_args: [f'-DTEST_CA_DIR="@TEST_CA_DIR@"', f'-DKEA_ADMIN="@TOP_BUILD_DIR@/src/bin/admin/kea-admin"'],
     dependencies: [GTEST_DEP, POSTGRESQL_DEP],
     include_directories: [include_directories('.')] + INCLUDES,
     link_with: [kea_util_unittests_lib, libs_testutils] + LIBS_BUILT_SO_FAR,
diff --git a/src/lib/process/meson.build b/src/lib/process/meson.build
index 1420a6d5bb..e1e029522b 100644
--- a/src/lib/process/meson.build
+++ b/src/lib/process/meson.build
@@ -12,7 +12,7 @@ kea_process_lib = shared_library(
     'log_parser.cc',
     'process_messages.cc',
     'redact_config.cc',
-    cpp_args: [f'-DPIDFILE_DIR="@LOCALSTATEDIR@/run/kea"'],
+    cpp_args: [f'-DPIDFILE_DIR="@PREFIX@/@LOCALSTATEDIR@/run/kea"'],
     dependencies: [GTEST_DEP],
     include_directories: [include_directories('.')] + INCLUDES,
     install: true,
diff --git a/src/lib/process/tests/meson.build b/src/lib/process/tests/meson.build
index 40ff589d58..af4a206d75 100644
--- a/src/lib/process/tests/meson.build
+++ b/src/lib/process/tests/meson.build
@@ -25,7 +25,7 @@ kea_process_tests = executable(
     cpp_args: [
         f'-DTEST_DATA_BUILDDIR="@current_build_dir@"',
         f'-DTEST_SCRIPT_SH="@current_build_dir@/process_test.sh"',
-        f'-DPIDFILE_DIR="@LOCALSTATEDIR@/run/kea"',
+        f'-DPIDFILE_DIR="@PREFIX@/@LOCALSTATEDIR@/run/kea"',
     ],
     include_directories: [include_directories('.')] + INCLUDES,
     link_with: [kea_util_unittests_lib, libs_testutils] + LIBS_BUILT_SO_FAR,